-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Data/Multiset/Order): add Dershowitz-Manna Ordering and Theorem #14411
base: master
Are you sure you want to change the base?
Conversation
PR summary dbd9cbbc82Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Can you please mark this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Some comments are general and need to be applied in other places in PR (instead of just committing the suggested portions).
Obviously my review is far from complete, but I'm not an expert here so hopefully someone else will come along, but these will give you something to start with. |
This PR/issue depends on:
|
I mean replacing |
- `Multiset.TransLT_eq_isDershowitzMannaLT` : two definitions of the `Dershowitz-Manna ordering` | ||
are equivalent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mention this since it's private
- `Multiset.TransLT_eq_isDershowitzMannaLT` : two definitions of the `Dershowitz-Manna ordering` | |
are equivalent. |
I have just pushed a golf. I am running out of time today, but you should feel free to have a look for yourself at my commit and try golfing further using the tricks you will have learned. 😃 |
Hi Thanks for showing some of the golfing tricks;-) @YaelDillies . I tried golfing a little bit more and maybe now it is in a better form. One thing that I am still unsure about is whether I am allowed to use aesop in the proof as long as it doesn't show 'time run out' thing? Is that what you meant by 'so long as performance is not too terrible'? Thanks! Ah I just saw some checks were not successful and I'm trying to understand what happened to the branch... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To answer the question regarding aesop
, you can write #count_heartbeats in
1 line before a lemma to see how much of a difference using aesop
changes, relevant scale for heartbeats is 200000.
Can you please merge master to get rid of the obscure CI error? |
Thanks again for another golf @YaelDillies ! I have to say it looks pretty clean to me now and I cannot see much to improve here ;-) Does it mean the PR is done now? Thanks! |
add Dershowitz-Manna Ordering and Theorem for Multisets
Co-authored-by: Malvin Gattinger [email protected]
https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Dershowitz-Manna.20Ordering.20theorem/near/434390710