Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/Multiset/Order): add Dershowitz-Manna Ordering and Theorem #14411

Closed
wants to merge 41 commits into from

Conversation

haitian-yuki
Copy link
Collaborator

@haitian-yuki haitian-yuki commented Jul 4, 2024

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

PR summary 85739c0726

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Data.Multiset.DershowitzManna (new file) 393

Declarations diff

+ IsDershowitzMannaLT
+ IsDershowitzMannaLT.trans
+ instWellFoundedisDershowitzMannaLT
+ wellFounded_isDershowitzMannaLT
++ add_add_tsub_cancel

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@riccardobrasca
Copy link
Member

Can you please mark this PR WIP or awaiting-review? Thanks!

@riccardobrasca riccardobrasca added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 4, 2024
Copy link
Collaborator

@Rida-Hamadani Rida-Hamadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some comments are general and need to be applied in other places in PR (instead of just committing the suggested portions).

@haitian-yuki haitian-yuki removed the awaiting-author A reviewer has asked the author a question or requested changes label Jul 10, 2024
@kim-em
Copy link
Contributor

kim-em commented Jul 17, 2024

Obviously my review is far from complete, but I'm not an expert here so hopefully someone else will come along, but these will give you something to start with.

@kim-em kim-em added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 18, 2024
@grunweg grunweg added the t-data Data (lists, quotients, numbers, etc) label Aug 15, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Aug 26, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Sep 19, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@haitian-yuki
Copy link
Collaborator Author

Thanks again for another golf @YaelDillies ! I have to say it looks pretty clean to me now and I cannot see much to improve here ;-) Does it mean the PR is done now? Thanks!

@YaelDillies
Copy link
Collaborator

I'm hoping to do a third golf pass at some point next week (I am completely submerged right now), then yes it should be good 😄

@YaelDillies
Copy link
Collaborator

Sorry for the delay, but here's the final golf. Thank you for your patience!

maintainer merge

Copy link

github-actions bot commented Jan 4, 2025

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kim-em
Copy link
Contributor

kim-em commented Jan 5, 2025

There's still an unresolved review comment above.

@kim-em
Copy link
Contributor

kim-em commented Jan 11, 2025

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 11, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 11, 2025
…14411)

add Dershowitz-Manna Ordering and Theorem for Multisets

Co-authored-by: Malvin Gattinger <[email protected]>



Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Malvin Gattinger <[email protected]>
Co-authored-by: Haitian <[email protected]>
Co-authored-by: Malvin Gattinger <[email protected]>
Co-authored-by: haitian-yuki <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 11, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jan 11, 2025
…14411)

add Dershowitz-Manna Ordering and Theorem for Multisets

Co-authored-by: Malvin Gattinger <[email protected]>



Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Malvin Gattinger <[email protected]>
Co-authored-by: Haitian <[email protected]>
Co-authored-by: Malvin Gattinger <[email protected]>
Co-authored-by: haitian-yuki <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 11, 2025

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jan 11, 2025
…14411)

add Dershowitz-Manna Ordering and Theorem for Multisets

Co-authored-by: Malvin Gattinger <[email protected]>



Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Malvin Gattinger <[email protected]>
Co-authored-by: Haitian <[email protected]>
Co-authored-by: Malvin Gattinger <[email protected]>
Co-authored-by: haitian-yuki <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 11, 2025

Build failed:

@bryangingechen
Copy link
Contributor

bors r+
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 12, 2025

✌️ haitian-yuki can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

mathlib-bors bot pushed a commit that referenced this pull request Jan 12, 2025
…14411)

add Dershowitz-Manna Ordering and Theorem for Multisets

Co-authored-by: Malvin Gattinger <[email protected]>



Co-authored-by: Yaël Dillies <[email protected]>
Co-authored-by: Malvin Gattinger <[email protected]>
Co-authored-by: Haitian <[email protected]>
Co-authored-by: Malvin Gattinger <[email protected]>
Co-authored-by: haitian-yuki <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 12, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Multiset/Order): add Dershowitz-Manna Ordering and Theorem [Merged by Bors] - feat(Data/Multiset/Order): add Dershowitz-Manna Ordering and Theorem Jan 12, 2025
@mathlib-bors mathlib-bors bot closed this Jan 12, 2025
@mathlib-bors mathlib-bors bot deleted the dm_ordering branch January 12, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.