-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Data/Multiset/Order): add Dershowitz-Manna Ordering and Theorem #14411
Conversation
PR summary 85739c0726Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Can you please mark this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Some comments are general and need to be applied in other places in PR (instead of just committing the suggested portions).
Obviously my review is far from complete, but I'm not an expert here so hopefully someone else will come along, but these will give you something to start with. |
This PR/issue depends on:
|
Thanks again for another golf @YaelDillies ! I have to say it looks pretty clean to me now and I cannot see much to improve here ;-) Does it mean the PR is done now? Thanks! |
I'm hoping to do a third golf pass at some point next week (I am completely submerged right now), then yes it should be good 😄 |
Sorry for the delay, but here's the final golf. Thank you for your patience! maintainer merge |
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There's still an unresolved review comment above. |
Co-authored-by: Yaël Dillies <[email protected]>
bors merge |
…14411) add Dershowitz-Manna Ordering and Theorem for Multisets Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: Yaël Dillies <[email protected]> Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: Haitian <[email protected]> Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: haitian-yuki <[email protected]>
Build failed (retrying...): |
…14411) add Dershowitz-Manna Ordering and Theorem for Multisets Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: Yaël Dillies <[email protected]> Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: Haitian <[email protected]> Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: haitian-yuki <[email protected]>
Build failed (retrying...): |
…14411) add Dershowitz-Manna Ordering and Theorem for Multisets Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: Yaël Dillies <[email protected]> Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: Haitian <[email protected]> Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: haitian-yuki <[email protected]>
Build failed: |
bors r+ |
✌️ haitian-yuki can now approve this pull request. To approve and merge a pull request, simply reply with |
…14411) add Dershowitz-Manna Ordering and Theorem for Multisets Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: Yaël Dillies <[email protected]> Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: Haitian <[email protected]> Co-authored-by: Malvin Gattinger <[email protected]> Co-authored-by: haitian-yuki <[email protected]>
Pull request successfully merged into master. Build succeeded: |
add Dershowitz-Manna Ordering and Theorem for Multisets
Co-authored-by: Malvin Gattinger [email protected]
https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/Dershowitz-Manna.20Ordering.20theorem/near/434390710