Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FieldTheory/Galois): Fundamental theorem of infinite galois theory #16982

Open
wants to merge 165 commits into
base: master
Choose a base branch
from

Conversation

Copy link

github-actions bot commented Sep 20, 2024

PR summary bd0c8d6807

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.FieldTheory.Galois.Infinite (new file) 1572

Declarations diff

+ GaloisCoinsertionIntermediateFieldSubgroup
+ GaloisInsertionIntermediateFieldSubgroup
+ IntermediateFieldEquivClosedSubgroup
+ finiteDimensional_of_le
+ fixedField_bot
+ fixedField_fixingSubgroup
+ fixingSubgroup_fixedField
+ fixingSubgroup_isClosed
+ instance : TopologicalSpace (K ≃ₐ[k] K) := inferInstance
+ mem_fixedField_iff
+ normal_iff_isGalois
+ open_iff_finite
+ restrict_fixedField

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Sep 20, 2024
Thmoas-Guan and others added 22 commits October 29, 2024 18:37
note: the exact number of heartbeats needed is 22133
using lemma already added better
resolved by lowering the priority of `IntermediateField.instIsScalarTowerSubtypeMem` to 900, see proting note for reason
the raise in heartbeat is no longer needed after the merge of #18436
1 fix namespace of restrictNormalHom_ker
2 fix naming of lift_algEquiv and add a basic API lemma for it
add a space

Co-authored-by: Thomas Browning <[email protected]>
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 1, 2024
@Thmoas-Guan Thmoas-Guan removed the WIP Work in progress label Dec 1, 2024
use intermediatefield.inclusion to reduce the proof of intermediatefield.finitedimensional_of_le
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants