Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: derivatives of matrix operations #19117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Nov 16, 2024

These are finally possible to state after #19108.

However, a lot of bundled ContinuousLinearMaps are missing.


Open in Gitpod

@eric-wieser eric-wieser added WIP Work in progress t-analysis Analysis (normed *, calculus) labels Nov 16, 2024
Copy link

github-actions bot commented Nov 16, 2024

PR summary 71948cdd47

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Analysis.Calculus.FDeriv.Matrix (new file) 1829
Mathlib.Analysis.Calculus.Deriv.Matrix (new file) 1832

Declarations diff

+ Differentiable.matrix_trace
+ Differentiable.matrix_transpose
+ DifferentiableAt.matrix_trace
+ DifferentiableAt.matrix_transpose
+ DifferentiableOn.matrix_trace
+ DifferentiableOn.matrix_transpose
+ DifferentiableWithinAt.matrix_trace
+ DifferentiableWithinAt.matrix_transpose
+ HasDerivAt.conjTranspose
+ HasDerivAt.matrix_hadamard
+ HasDerivAt.matrix_inv
+ HasDerivAt.matrix_kronecker
+ HasDerivAt.matrix_mul
+ HasDerivAt.trace
+ HasDerivAt.transpose
+ HasFDerivAt.matrix_conjTranspose
+ HasFDerivAt.matrix_mul
+ HasFDerivAt.matrix_trace
+ HasFDerivAt.matrix_transpose
+ HasFDerivAtFilter.matrix_conjTranspose
+ HasFDerivAtFilter.matrix_trace
+ HasFDerivAtFilter.matrix_transpose
+ HasFDerivWithinAt.matrix_trace
+ HasFDerivWithinAt.matrix_transpose
+ deriv_matrix
+ differentiableAt_matrix
+ differentiableOn_matrix
+ differentiableWithinAt_matrix
+ differentiable_matrix
+ hasDerivAt_matrix
+ hasFDerivAtFilter_matrix
+ hasFDerivAt_matrix
+ hasFDerivWithinAt_matrix

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (5.04, 0.00)
Current number Change Type
4843 2 porting notes
1520 6 erw

Current commit 71948cdd47
Reference commit d4736a1fb2

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Nov 16, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 2, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 24, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

@eric-wieser eric-wieser force-pushed the eric-wieser/matrix-derivatives branch from f4c110f to 71948cd Compare December 24, 2024 10:22
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-analysis Analysis (normed *, calculus) WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants