Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/BigOperators/Group/Finset) : Finset.prod_disjoint_filters #19712

Closed
wants to merge 11 commits into from

Conversation

mans0954
Copy link
Collaborator

@mans0954 mans0954 commented Dec 3, 2024

Decomposes the product(sum) over two filters where they are pointwise disjoint.

Used in #19432


Open in Gitpod

@mans0954 mans0954 added the WIP Work in progress label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

PR summary e7c1c71f7d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ disjoint_filter_and_not_filter
+ prod_filter_xor

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Dec 3, 2024
@mans0954 mans0954 changed the title WiP disjoint_of_not_and_on_set feat(Algebra/BigOperators/Group/Finset) : Dec 4, 2024
@mans0954 mans0954 changed the title feat(Algebra/BigOperators/Group/Finset) : feat(Algebra/BigOperators/Group/Finset) : Finset.prod_disjoint_filters Dec 4, 2024
@mans0954 mans0954 added t-algebra Algebra (groups, rings, fields, etc) and removed WIP Work in progress t-data Data (lists, quotients, numbers, etc) labels Dec 4, 2024
@mans0954 mans0954 marked this pull request as ready for review December 4, 2024 08:11
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Dec 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Dec 5, 2024
#19712)

Decomposes the product(sum) over two filters where they are pointwise disjoint.

Used in #19432



Co-authored-by: Christopher Hoskin <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/BigOperators/Group/Finset) : Finset.prod_disjoint_filters [Merged by Bors] - feat(Algebra/BigOperators/Group/Finset) : Finset.prod_disjoint_filters Dec 5, 2024
@mathlib-bors mathlib-bors bot closed this Dec 5, 2024
@mathlib-bors mathlib-bors bot deleted the mans0954/sum_disjoint_filters branch December 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants