Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: make Sub ℝ≥0 and Sub ℝ≥0∞ computable #20856

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 19, 2025

This comes for free by relaxing some unnecessarily-strong typeclass requirements.

(as a reminder, LinearOrder NNReal is noncomputable as it contains noncomputable Decidable instances)


Open in Gitpod

Copy link

github-actions bot commented Jan 19, 2025

PR summary 871423b0d7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@eric-wieser eric-wieser force-pushed the eric-wieser/computable-nnreal-sub branch from aef1d53 to 5372dfd Compare January 19, 2025 21:44
@eric-wieser eric-wieser changed the title feat: make Sub ℝ≥0 computable feat: make Sub ℝ≥0 and Sub ℝ≥0∞ computable Jan 19, 2025
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless assuming it builds.

maintainer delegate

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@eric-wieser
Copy link
Member Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 871423b.
There were no significant changes against commit a1ad6eb.

Copy link

File Instructions %
build -11.239⬝10⁹ (+0.00%)
CI run

@RemyDegenne
Copy link
Contributor

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 20, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 20, 2025
This comes for free by relaxing some unnecessarily-strong typeclass requirements.

(as a reminder, `LinearOrder NNReal` is noncomputable as it contains noncomputable `Decidable` instances)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 20, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: make Sub ℝ≥0 and Sub ℝ≥0∞ computable [Merged by Bors] - feat: make Sub ℝ≥0 and Sub ℝ≥0∞ computable Jan 20, 2025
@mathlib-bors mathlib-bors bot closed this Jan 20, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser/computable-nnreal-sub branch January 20, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants