-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: make Sub ℝ≥0
and Sub ℝ≥0∞
computable
#20856
Conversation
PR summary 871423b0d7Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
aef1d53
to
5372dfd
Compare
Sub ℝ≥0
computableSub ℝ≥0
and Sub ℝ≥0∞
computable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems harmless assuming it builds.
maintainer delegate
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
!bench |
Here are the benchmark results for commit 871423b. |
|
bors r+ |
This comes for free by relaxing some unnecessarily-strong typeclass requirements. (as a reminder, `LinearOrder NNReal` is noncomputable as it contains noncomputable `Decidable` instances)
Pull request successfully merged into master. Build succeeded: |
Sub ℝ≥0
and Sub ℝ≥0∞
computableSub ℝ≥0
and Sub ℝ≥0∞
computable
This comes for free by relaxing some unnecessarily-strong typeclass requirements.
(as a reminder,
LinearOrder NNReal
is noncomputable as it contains noncomputableDecidable
instances)