chore: adaptations for nightly-2024-10-17 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Oct 18, 2024
Qq/ForLean/ReduceEval.lean
Outdated
| reduceEval := fun e => do | ||
| let e ← whnf e | ||
| if e.isAppOfArity ``BitVec.ofFin 2 then | ||
| have : 2^n - 1 + 1 = 2^n := Nat.sub_one_add_one_eq_of_pos (Nat.two_pow_pos n) |
There was a problem hiding this comment.
I just created #61 which should make this unnecessary. Could you rebase and see if you can remove all the -1s?
There was a problem hiding this comment.
Ah nevermind, I just did it.
eric-wieser
approved these changes
Oct 18, 2024
I thought you said you weren't going to merge this into master? |
|
I've force pushed master to roll this back, and pushed 0dc6370 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note this is a PR for bump/v4.14.0, not master. We can review this now, and then we'll merge bump/v4.14.0 into master on release day.)