Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't treat non-atomic idents as pattern variables #6551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: don't treat non-atomic idents as pattern variables #6551

wants to merge 1 commit into from

Conversation

cppio
Copy link
Contributor

@cppio cppio commented Jan 6, 2025

This PR fixes the pattern variable check to reject non-atomic idents when they exist in the environment.

Closes #6537

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 6, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 6, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 76f883b9995f684663e3106b08defec46f7a7f4c --onto 78ddee911287bf7b0069a695b01001db2654a765. (2025-01-06 14:00:48)
  • ✅ Mathlib branch lean-pr-testing-6551 has successfully built against this PR. (2025-01-07 03:58:35) View Log

@nomeata nomeata mentioned this pull request Jan 6, 2025
Open
3 tasks
@cppio cppio force-pushed the non-atomic-pattern-var branch from 601e602 to 6419f1b Compare January 7, 2025 02:49
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 7, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6551
61b02b5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 7, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6551
af356e7
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 7, 2025
@cppio
Copy link
Contributor Author

cppio commented Jan 8, 2025

changelog-language

@github-actions github-actions bot added the changelog-language Language features, tactics, and metaprograms label Jan 8, 2025
@cppio cppio marked this pull request as draft January 8, 2025 04:02
@cppio cppio marked this pull request as ready for review January 8, 2025 04:02
@leanprover-bot leanprover-bot added the P-low We are not planning to work on this issue label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms P-low We are not planning to work on this issue toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing error for non-atomic pattern variable
3 participants
@cppio @leanprover-community-bot @leanprover-bot