Skip to content

Update format & lean, handle mdata #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ammkrn
Copy link

@ammkrn ammkrn commented Jan 11, 2024

nanoda_lib assumes these changes; if you're ready to pull the trigger, here's the PR. If you want to keep it in a separate branch for now, I'm fine with that too, I'll update the checker's readme.

@siddhartha-gadgil this will be a small but breaking change relative to what you were doing. Please jump in if you have any concerns.

@siddhartha-gadgil
Copy link
Contributor

What does it break @ammkrn ?

I was working on porting trepplein though that is on hold for a while. I can adapt as long as the export format is as documented and has enough information for a typechecker.

@siddhartha-gadgil
Copy link
Contributor

Perhaps this breaks some hacks I had about spaces at the end of lines. If so that is fine - I will implement a better solution than the hacks.

@ammkrn
Copy link
Author

ammkrn commented Jan 11, 2024

The breaks should only require adjustments in the parser, the logical components of your checker should be unaffected. The parser breaks should be that theorem and opaque now have their own tags instead of using #DEF, definition lines have the reduction hint included, quotient is now four separate declarations instead of one #QUOT tag, and the contents of inductive/constructor lines have changed slightly.

The updated format is laid out in full in the updated README.

mdata nodes are pruned, but that shouldn't be breaking since the underlying expressions are still exported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants