fix: proper error handling for period submission. (#363)

We were prematurely marking the period as submitted (in updatePeriod).
The code which was supposed to do that in `submitPeriod` was broken and never really called.

Additionally, logging period submission errors now.

src/block/updatePeriod.js

@@ -26,7 +26,6 @@ module.exports = async (state, chainInfo, bridgeState, sender) => {
           bridgeState.periodHeights[pendingPeriodRoot],
           bridgeState
         );
-        bridgeState.submittedPeriods[pendingPeriodRoot] = true;
       } catch (err) {
         /* istanbul ignore next */
         logPeriod(`submit period: ${err}`);

src/txHelpers/submitPeriod.js

@@ -99,18 +99,17 @@ module.exports = async (period, slots, height, bridgeState) => {
       ),
       bridgeState.operatorContract.options.address,
       bridgeState.account
-    ).catch(
-      /* istanbul ignore next */ () => {
-        delete inFlight[periodRoot];
-        logError(height);
-      }
-    );
+    ).catch((e) => {
+      logPeriod('submitPeriod error', e);
+      delete inFlight[periodRoot];
+      logError(height);
+    });
 
     tx.then(receipt => {
       logPeriod('submitPeriod tx', receipt);
       delete inFlight[periodRoot];
-      if (receipt && receipt.status === 1) {
-        bridgeState.submittedPeriod[periodRoot] = true;
+      if (receipt && receipt.status) {
+        bridgeState.submittedPeriods[periodRoot] = true;
       }
     });
   }