PR: form-review:#2- added personal information component no css, pulled branch RB-design #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagunji
reviewed
Apr 17, 2020
|
@nikitashrestha Please add descriptions on your PR. you can bullet points things you have done. Its good that you mentioned pulled branch RB-design but it would be better to be added in the description and not in the title itself :D Also, @Esha-Rajbhandari might push new changes because I have made some comments on it. Please, pull her branch once more as hers is merged or collaborate her to make changes on this branch. |
sagunji
reviewed
Apr 17, 2020
sagunji
reviewed
Apr 17, 2020
sagunji
reviewed
Apr 17, 2020
sagunji
reviewed
Apr 17, 2020
sagunji
reviewed
Apr 20, 2020
sagunji
reviewed
Apr 21, 2020
sagunji
reviewed
Apr 21, 2020
sagunji
reviewed
Apr 21, 2020
src/pages/index.js
Outdated
| const [preview, setPreview] = useState(false); | ||
|
|
||
| // Data source | ||
| const data = { |
There was a problem hiding this comment.
You can place it to /constant folder as mockData.js and import it in App file.
sagunji
reviewed
Apr 23, 2020
sagunji
reviewed
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.