fix: Ledger - cancel properly and don't allow user to close non cancellable sections #5598
Annotations
4 errors, 2 warnings, and 1 notice
Run Playwright tests:
tests/specs/rpc-get-addresses/get-addresses.spec.ts#L11
1) [chromium] › specs/rpc-get-addresses/get-addresses.spec.ts:97:7 › Rpc: GetAddresses › softwareWallet › the promise resolves with addresses successfully
Test timeout of 30000ms exceeded while running "beforeEach" hook.
9 | function softwareBeforeEach() {
10 | return () =>
> 11 | test.beforeEach(
| ^
12 | async ({ extensionId, onboardingPage }) =>
13 | await onboardingPage.signInWithTestAccount(extensionId)
14 | );
at /home/runner/work/extension/extension/tests/specs/rpc-get-addresses/get-addresses.spec.ts:11:10
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L286
1) [chromium] › specs/rpc-get-addresses/get-addresses.spec.ts:97:7 › Rpc: GetAddresses › softwareWallet › the promise resolves with addresses successfully
Error: page.evaluate: Target page, context or browser has been closed
at page-object-models/onboarding.page.ts:286
284 | const isUnlockPage = async () => await this.page.getByText('Enter your password').isVisible();
285 | while (!(await isUnlockPage())) {
> 286 | await this.page.evaluate(
| ^
287 | async walletState => await chrome.storage.local.set({ 'persist:root': walletState }),
288 | testSoftwareAccountDefaultWalletState
289 | );
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:286:23)
at /home/runner/work/extension/extension/tests/specs/rpc-get-addresses/get-addresses.spec.ts:13:9
|
Run Playwright tests:
tests/specs/rpc-get-addresses/get-addresses.spec.ts#L11
2) [chromium] › specs/rpc-get-addresses/get-addresses.spec.ts:120:9 › Rpc: GetAddresses › softwareWallet › it redirects back to get addresses flow when wallet is locked
Test timeout of 30000ms exceeded while running "beforeEach" hook.
9 | function softwareBeforeEach() {
10 | return () =>
> 11 | test.beforeEach(
| ^
12 | async ({ extensionId, onboardingPage }) =>
13 | await onboardingPage.signInWithTestAccount(extensionId)
14 | );
at /home/runner/work/extension/extension/tests/specs/rpc-get-addresses/get-addresses.spec.ts:11:10
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L290
2) [chromium] › specs/rpc-get-addresses/get-addresses.spec.ts:120:9 › Rpc: GetAddresses › softwareWallet › it redirects back to get addresses flow when wallet is locked
Error: page.goto: Target page, context or browser has been closed
Call log:
- navigating to "chrome-extension://ecglnfnhimaihdkpolkogpngodkkjhdm/index.html", waiting until "load"
at page-object-models/onboarding.page.ts:290
288 | testSoftwareAccountDefaultWalletState
289 | );
> 290 | await this.page.goto(`chrome-extension://${id}/index.html`);
| ^
291 | }
292 | await test.expect(this.page.getByText('Enter your password')).toBeVisible();
293 | await this.page.getByRole('textbox').fill(TEST_PASSWORD);
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:290:23)
at /home/runner/work/extension/extension/tests/specs/rpc-get-addresses/get-addresses.spec.ts:13:9
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: nick-fields/retry@v2, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "all-blob-reports".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Run Playwright tests
2 flaky
[chromium] › specs/rpc-get-addresses/get-addresses.spec.ts:97:7 › Rpc: GetAddresses › softwareWallet › the promise resolves with addresses successfully
[chromium] › specs/rpc-get-addresses/get-addresses.spec.ts:120:9 › Rpc: GetAddresses › softwareWallet › it redirects back to get addresses flow when wallet is locked
7 passed (2.5m)
|
Loading