fix: Ledger - cancel properly and don't allow user to close non cancellable sections #5599
Annotations
10 errors, 2 warnings, and 1 notice
Run Playwright tests:
tests/specs/send/send-stx.spec.ts#L18
1) [chromium] › specs/send/send-stx.spec.ts:117:5 › send stx: tests on testnet › send form validation › that the address must be valid
Test timeout of 30000ms exceeded while running "beforeEach" hook.
16 |
17 | test.describe('send stx: tests on testnet', () => {
> 18 | test.beforeEach(async ({ extensionId, globalPage, homePage, onboardingPage, sendPage }) => {
| ^
19 | await globalPage.setupAndUseApiCalls(extensionId);
20 | await onboardingPage.signInWithTestAccount(extensionId);
21 | await homePage.selectTestNet();
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:18:8
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L284
1) [chromium] › specs/send/send-stx.spec.ts:117:5 › send stx: tests on testnet › send form validation › that the address must be valid
Error: locator.isVisible: Target page, context or browser has been closed
Call log:
- checking visibility of getByText('Enter your password')
at page-object-models/onboarding.page.ts:284
282 | */
283 | async signInWithTestAccount(id: string) {
> 284 | const isUnlockPage = async () => await this.page.getByText('Enter your password').isVisible();
| ^
285 | while (!(await isUnlockPage())) {
286 | await this.page.evaluate(
287 | async walletState => await chrome.storage.local.set({ 'persist:root': walletState }),
at isUnlockPage (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:284:87)
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:285:20)
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:20:5
|
Run Playwright tests:
tests/specs/send/send-stx.spec.ts#L18
2) [chromium] › specs/send/send-stx.spec.ts:132:5 › send stx: tests on testnet › send form validation › that valid addresses are accepted
Test timeout of 30000ms exceeded while running "beforeEach" hook.
16 |
17 | test.describe('send stx: tests on testnet', () => {
> 18 | test.beforeEach(async ({ extensionId, globalPage, homePage, onboardingPage, sendPage }) => {
| ^
19 | await globalPage.setupAndUseApiCalls(extensionId);
20 | await onboardingPage.signInWithTestAccount(extensionId);
21 | await homePage.selectTestNet();
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:18:8
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L290
2) [chromium] › specs/send/send-stx.spec.ts:132:5 › send stx: tests on testnet › send form validation › that valid addresses are accepted
Error: page.goto: Target page, context or browser has been closed
Call log:
- navigating to "chrome-extension://ecglnfnhimaihdkpolkogpngodkkjhdm/index.html", waiting until "load"
at page-object-models/onboarding.page.ts:290
288 | testSoftwareAccountDefaultWalletState
289 | );
> 290 | await this.page.goto(`chrome-extension://${id}/index.html`);
| ^
291 | }
292 | await test.expect(this.page.getByText('Enter your password')).toBeVisible();
293 | await this.page.getByRole('textbox').fill(TEST_PASSWORD);
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:290:23)
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:20:5
|
Run Playwright tests:
tests/specs/send/send-stx.spec.ts#L18
3) [chromium] › specs/send/send-stx.spec.ts:142:5 › send stx: tests on testnet › send form preview › send form preview: that it shows preview of tx details to be confirmed
Test timeout of 30000ms exceeded while running "beforeEach" hook.
16 |
17 | test.describe('send stx: tests on testnet', () => {
> 18 | test.beforeEach(async ({ extensionId, globalPage, homePage, onboardingPage, sendPage }) => {
| ^
19 | await globalPage.setupAndUseApiCalls(extensionId);
20 | await onboardingPage.signInWithTestAccount(extensionId);
21 | await homePage.selectTestNet();
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:18:8
|
Run Playwright tests:
tests/page-object-models/home.page.ts#L107
3) [chromium] › specs/send/send-stx.spec.ts:142:5 › send stx: tests on testnet › send form preview › send form preview: that it shows preview of tx details to be confirmed
Error: page.waitForTimeout: Target page, context or browser has been closed
at page-object-models/home.page.ts:107
105 | await this.page.getByTestId(NetworkSelectors.NetworkListActiveNetwork).isVisible();
106 |
> 107 | await this.page.waitForTimeout(1000);
| ^
108 | await this.page.getByTestId(WalletDefaultNetworkConfigurationIds.testnet).click();
109 | }
110 |
at HomePage.selectTestNet (/home/runner/work/extension/extension/tests/page-object-models/home.page.ts:107:21)
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:21:5
|
Run Playwright tests:
tests/specs/send/send-stx.spec.ts#L172
4) [chromium] › specs/send/send-stx.spec.ts:195:5 › send stx: tests on mainnet › send form input fields › that fee row defaults to middle fee estimation
Test timeout of 30000ms exceeded while running "beforeEach" hook.
170 | // Those that can should be migrated to testnet tests
171 | test.describe('send stx: tests on mainnet', () => {
> 172 | test.beforeEach(async ({ extensionId, globalPage, onboardingPage, homePage, sendPage }) => {
| ^
173 | await globalPage.setupAndUseApiCalls(extensionId);
174 | await onboardingPage.signInWithTestAccount(extensionId);
175 | await homePage.sendButton.click();
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:172:8
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L290
4) [chromium] › specs/send/send-stx.spec.ts:195:5 › send stx: tests on mainnet › send form input fields › that fee row defaults to middle fee estimation
Error: page.goto: Target page, context or browser has been closed
Call log:
- navigating to "chrome-extension://ecglnfnhimaihdkpolkogpngodkkjhdm/index.html", waiting until "load"
at page-object-models/onboarding.page.ts:290
288 | testSoftwareAccountDefaultWalletState
289 | );
> 290 | await this.page.goto(`chrome-extension://${id}/index.html`);
| ^
291 | }
292 | await test.expect(this.page.getByText('Enter your password')).toBeVisible();
293 | await this.page.getByRole('textbox').fill(TEST_PASSWORD);
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:290:23)
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:174:5
|
Run Playwright tests:
tests/specs/send/send-stx.spec.ts#L172
5) [chromium] › specs/send/send-stx.spec.ts:205:5 › send stx: tests on mainnet › send form input fields › that low fee estimate can be selected
Test timeout of 30000ms exceeded while running "beforeEach" hook.
170 | // Those that can should be migrated to testnet tests
171 | test.describe('send stx: tests on mainnet', () => {
> 172 | test.beforeEach(async ({ extensionId, globalPage, onboardingPage, homePage, sendPage }) => {
| ^
173 | await globalPage.setupAndUseApiCalls(extensionId);
174 | await onboardingPage.signInWithTestAccount(extensionId);
175 | await homePage.sendButton.click();
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:172:8
|
Run Playwright tests:
tests/page-object-models/onboarding.page.ts#L290
5) [chromium] › specs/send/send-stx.spec.ts:205:5 › send stx: tests on mainnet › send form input fields › that low fee estimate can be selected
Error: page.goto: Target page, context or browser has been closed
Call log:
- navigating to "chrome-extension://ecglnfnhimaihdkpolkogpngodkkjhdm/index.html", waiting until "load"
at page-object-models/onboarding.page.ts:290
288 | testSoftwareAccountDefaultWalletState
289 | );
> 290 | await this.page.goto(`chrome-extension://${id}/index.html`);
| ^
291 | }
292 | await test.expect(this.page.getByText('Enter your password')).toBeVisible();
293 | await this.page.getByRole('textbox').fill(TEST_PASSWORD);
at OnboardingPage.signInWithTestAccount (/home/runner/work/extension/extension/tests/page-object-models/onboarding.page.ts:290:23)
at /home/runner/work/extension/extension/tests/specs/send/send-stx.spec.ts:174:5
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: nick-fields/retry@v2, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "all-blob-reports".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Run Playwright tests
5 flaky
[chromium] › specs/send/send-stx.spec.ts:117:5 › send stx: tests on testnet › send form validation › that the address must be valid
[chromium] › specs/send/send-stx.spec.ts:132:5 › send stx: tests on testnet › send form validation › that valid addresses are accepted
[chromium] › specs/send/send-stx.spec.ts:142:5 › send stx: tests on testnet › send form preview › send form preview: that it shows preview of tx details to be confirmed
[chromium] › specs/send/send-stx.spec.ts:195:5 › send stx: tests on mainnet › send form input fields › that fee row defaults to middle fee estimation
[chromium] › specs/send/send-stx.spec.ts:205:5 › send stx: tests on mainnet › send form input fields › that low fee estimate can be selected
5 passed (5.1m)
|
Loading