-
Notifications
You must be signed in to change notification settings - Fork 146
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #5100 from leather-wallet/release/gltf-support
Release/gltf support
- Loading branch information
Showing
106 changed files
with
25,794 additions
and
22,953 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Contributing | ||
|
|
||
| Anyone is welcome to help make Leather better. We encourage contributors to let us know via Github issues what they’d like to work on. We’re happy to help get you started. | ||
|
|
||
| Leather aims to respond to contributor PRs within 2 working days. | ||
|
|
||
| ## Bugs | ||
|
|
||
| If you’ve found a bug, first check to see if an issue already exists. If so, add a comment to let us know you found it too. Otherwise, open up an issue describing in as much detail as possible how we’d be able to recreate it. | ||
|
|
||
| If you’re a developer, feel free to submit a Pull Request with a suggested fix. | ||
|
|
||
| ## Feature enhancements | ||
|
|
||
| There is a long list of features we want to add to Leather, and we’d love help working on them. Please be aware, your work will only be merged if it aligns with Leather’s product roadmap and conforms to Leather’s standards. | ||
|
|
||
| ## Coding standards | ||
|
|
||
| Code contributions must follow the style and patterns already employed by the project. This list of requirements is non-exhaustive. The Leather team might ask for additional changes. | ||
|
|
||
| - Code must conform to our linting setup `pnpm lint` | ||
| - Code formatting correctly `pnpm prettier` | ||
| - Code must be typed properly with Typescript `pnpm typecheck` | ||
|
|
||
| ## Testing | ||
|
|
||
| Code should be tested thoroughly. Complex logic must be unit tested. User flows should be covered with integration tests using [Playwright](https://playwright.dev/). | ||
|
|
||
| ## Support | ||
|
|
||
| The Leather team is happy to help. If you need more involved guidance for your contribution, please allow some additional time for the team to respond to your queries. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| name: 'Check package version lock' | ||
| description: Checks all versions are installed with exact version | ||
| runs: | ||
| using: 'node16' | ||
| using: 'node20' | ||
| main: 'check-version-lock.js' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ jobs: | |
|
|
||
| - uses: kyranjamie/[email protected] | ||
| with: | ||
| header: '> _Building Leather at commit `${{ env.SHORT_SHA }}`_' | ||
| header: '> _Building Leather at commit ${{ env.SHORT_SHA }}_' | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| build: | ||
|
|
@@ -42,7 +42,7 @@ jobs: | |
| - run: echo "SHORT_SHA=`echo ${{ github.event.pull_request.head.sha }} | cut -c1-7`" >> $GITHUB_ENV | ||
|
|
||
| - name: Build project | ||
| run: yarn build | ||
| run: pnpm build | ||
| env: | ||
| WALLET_ENVIRONMENT: feature | ||
| TARGET_BROWSER: ${{ matrix.target }} | ||
|
|
@@ -61,12 +61,32 @@ jobs: | |
| name: leather-${{ matrix.target }}-${{ env.SHORT_SHA }} | ||
| path: dist | ||
|
|
||
| chromatic: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| storybook_url: ${{ steps.chromatic.outputs.storybookUrl }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - uses: ./.github/actions/provision | ||
|
|
||
| - name: Deploy to Chromatic | ||
| id: chromatic | ||
| uses: chromaui/action@latest | ||
| with: | ||
| autoAcceptChanges: 'main' | ||
| projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| set-download-link: | ||
| if: github.repository == 'leather-wallet/extension' && github.actor != 'dependabot[bot]' | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - pre-run | ||
| - build | ||
| - chromatic | ||
| steps: | ||
| - name: Extract branch name | ||
| shell: bash | ||
|
|
@@ -75,5 +95,5 @@ jobs: | |
|
|
||
| - uses: kyranjamie/[email protected] | ||
| with: | ||
| header: '> Try out this version of Leather — [Extension build](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}), [Test report](https://leather-wallet.github.io/playwright-reports/${{ steps.extract_branch.outputs.branch }})' | ||
| header: '> Try out this version of Leather — [Extension build](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}), [Test report](https://leather-wallet.github.io/playwright-reports/${{ steps.extract_branch.outputs.branch }}), [Storybook preview](${{ needs.chromatic.outputs.storybook_url }})' | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: Contributor automation | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: opened | ||
|
|
||
| jobs: | ||
| fork-detection: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| issues: write | ||
| # When a fork | ||
| if: github.event.pull_request.head.repo.full_name != github.repository && github.actor != 'dependabot[bot]' | ||
| steps: | ||
| - name: Add contributor advice | ||
| uses: peter-evans/create-or-update-comment@v4 | ||
| with: | ||
| issue-number: ${{ github.event.pull_request.number }} | ||
| token: ${{ secrets.LEATHER_BOT }} | ||
| body: | | ||
| Thanks for contributing to Leather! Our team will review your PR and get back to you as soon as possible. | ||
| Please make sure to follow our [Contributor Guidelines][1] | ||
| [1]: https://github.com/leather-wallet/extension/tree/dev/.github/CONTRIBUTING.md | ||
| - name: Add label | ||
| run: gh issue edit "$NUMBER" --add-label "$LABELS" | ||
| env: | ||
| GH_TOKEN: ${{ secrets.LEATHER_BOT }} | ||
| GH_REPO: ${{ github.repository }} | ||
| NUMBER: ${{ github.event.pull_request.number }} | ||
| LABELS: 'needs:internal-review' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,43 +14,43 @@ jobs: | |
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: ./.github/actions/provision | ||
| - uses: actions/setup-node@v3 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18 | ||
|
|
||
| - uses: actions/cache@v3 | ||
| - uses: actions/cache@v4 | ||
| id: cache | ||
| with: | ||
| path: '**/node_modules' | ||
| key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}-${{ hashFiles('**/package.json') }} | ||
| key: ${{ runner.os }}-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ hashFiles('**/package.json') }} | ||
|
|
||
| - name: Install dependencies | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| env: | ||
| PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 | ||
| run: yarn --frozen-lockfile | ||
| run: pnpm install --frozen-lockfile | ||
| shell: bash | ||
|
|
||
| - name: Get installed Playwright version | ||
| id: playwright-version | ||
| run: echo "PLAYWRIGHT_VERSION=$(node -e "console.log(require('./package.json').devDependencies['@playwright/test'])")" >> $GITHUB_ENV | ||
|
|
||
| - name: Cache playwright binaries | ||
| uses: actions/cache@v3 | ||
| uses: actions/cache@v4 | ||
| id: playwright-cache | ||
| with: | ||
| path: ~/.cache/ms-playwright | ||
| key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }} | ||
|
|
||
| - name: Install Playwright deps | ||
| run: yarn playwright install chrome | ||
| run: pnpm playwright install chrome | ||
| if: steps.playwright-cache.outputs.cache-hit != 'true' | ||
|
|
||
| - name: Run Playwright tests | ||
| id: playwright | ||
| uses: mathiasvr/[email protected] | ||
| with: | ||
| run: yarn playwright test --reporter=github tests/api | ||
| run: pnpm playwright test --reporter=github tests/api | ||
|
|
||
| - name: Truncate String | ||
| uses: 2428392/[email protected] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.