test: ensure only public keys passed to 'sendRequestAccountResponseTo…

…Tab'

src/app/common/actions/send-request-account-response.spec.ts

@@ -0,0 +1,24 @@
+import { sendRequestAccountResponseToTab } from './send-request-account-response';
+import { sendMessageToTab } from '@shared/messages';
+
+jest.mock('@shared/messages', () => ({
+  sendMessageToTab: jest.fn().mockImplementation(() => null),
+}));
+
+describe(sendRequestAccountResponseToTab.name, () => {
+  it('must only return to app with public keys', () => {
+    sendRequestAccountResponseToTab({
+      tabId: '2',
+      id: '1',
+      account: {
+        stxPublicKey: 'pubKey1',
+        dataPublicKey: 'dataKey1',
+        stxPrivateKey: 'lskdjfjsldf',
+      } as any,
+    });
+    expect(sendMessageToTab).toHaveBeenCalledTimes(1);
+    expect(sendMessageToTab).toHaveBeenCalledWith(2, '1', [
+      { dataPublicKey: 'dataKey1', stxPublicKey: 'pubKey1' },
+    ]);
+  });
+});

src/app/common/actions/send-request-account-response.ts

@@ -14,5 +14,5 @@ export function sendRequestAccountResponseToTab(args: SendRequestAccountResponse
     dataPublicKey: account.dataPublicKey,
   };
 
-  return sendMessageToTab(parseInt(tabId), id, safeAccountKeys);
+  return sendMessageToTab(parseInt(tabId), id, [safeAccountKeys]);
 }

src/app/pages/choose-account-request/account-request.tsx

@@ -21,7 +21,7 @@ export function AccountRequest() {
     if (!accounts) throw new Error('Cannot request account details with no account');
 
     if (!tabId || !id) {
-      logger.error('Missing either tabId or uuid. Both necessary to respond to app');
+      logger.error('Missing either tabId or uuid. Both values are necessary to respond to app');
       return;
     }