fix: always set memo for SIP10, ref #5436

leather-io · May 24, 2024 · fe1b75f · fe1b75f
1 parent d910b9a
commit fe1b75f
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/src/app/store/transactions/token-transfer.hooks.ts b/src/app/store/transactions/token-transfer.hooks.ts
@@ -86,11 +86,9 @@ export function useGenerateFtTokenTransferUnsignedTx(info: Sip10CryptoAssetInfo)
   const { contractId } = info;
   const { contractAddress, contractAssetName, contractName } =
     getStacksContractIdStringParts(contractId);
-
   return useCallback(
     async (values?: StacksSendFormValues | StacksTransactionFormValues) => {
       try {
-        debugger;
         if (!account) return;
 
         const functionName = 'transfer';
@@ -102,7 +100,7 @@ export function useGenerateFtTokenTransferUnsignedTx(info: Sip10CryptoAssetInfo)
         const memo =
           values && 'memo' in values && values.memo !== ''
             ? someCV(bufferCVFromString(values.memo || ''))
-            : noneCV();
+            : noneCV(); // memo set to noneCV here
 
         const amountAsFractionalUnit = ftUnshiftDecimals(amount, info.decimals || 0);
         const postConditionOptions = {
@@ -122,9 +120,7 @@ export function useGenerateFtTokenTransferUnsignedTx(info: Sip10CryptoAssetInfo)
           standardPrincipalCVFromAddress(recipient),
         ];
 
-        if (info.hasMemo) {
-          functionArgs.push(memo);
-        }
+        functionArgs.push(memo);
 
         const options = {
           txData: {
@@ -145,15 +141,13 @@ export function useGenerateFtTokenTransferUnsignedTx(info: Sip10CryptoAssetInfo)
 
         return generateUnsignedTransaction(options);
       } catch (error) {
-        debugger;
         logger.error('Failed to generate unsigned transaction', error);
         return;
       }
     },
     [
       account,
       info.decimals,
-      info.hasMemo,
       network,
       nextNonce?.nonce,
       contractName,