Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show correct addresses when connected to devnet or regtest #4223

Closed
stjepangolemac opened this issue Sep 14, 2023 · 0 comments · Fixed by #4331
Closed

Show correct addresses when connected to devnet or regtest #4223

stjepangolemac opened this issue Sep 14, 2023 · 0 comments · Fixed by #4331
Assignees
@kyranjamie
Labels
area:networks bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds

Comments

@stjepangolemac
Copy link

stjepangolemac commented Sep 14, 2023 •
edited
Loading

Original issue where we've discovered this is here.

When you connect to an auto-discovered local devnet from Leather it shows a testnet BTC main address. The ordinal BTC address is regtest and correct.

If you add a new network entry that connects to the same local devnet both cardinal and ordinal BTC addresses are testnet when they should show regtest ones.

Auto-discovered devnet

image

Manual entry devnet

image
@markmhendrickson markmhendrickson added bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds area:networks labels Sep 15, 2023
@radicleart radicleart mentioned this issue Sep 18, 2023
Open
@friedger friedger mentioned this issue Oct 4, 2023
Open
@markmhendrickson markmhendrickson changed the title Chrome extension shows wrong addresses when connected to devnet Show correct addresses when connected to devnet or regtest Oct 6, 2023
@kyranjamie kyranjamie assigned kyranjamie and unassigned fbwoolf Oct 6, 2023
@kyranjamie kyranjamie mentioned this issue Oct 6, 2023
Closed
kyranjamie added a commit that referenced this issue Oct 6, 2023
@kyranjamie
fix: regtest addresses, closes #4223
bddd2d9
@kyranjamie kyranjamie linked a pull request Oct 6, 2023 that will close this issue
fix: regtest addresses, closes #4223 #4331
Merged
kyranjamie added a commit that referenced this issue Oct 6, 2023
@kyranjamie
fix: regtest addresses, closes #4223
6fa34a6
kyranjamie added a commit that referenced this issue Oct 6, 2023
@kyranjamie
fix: regtest addresses, closes #4223
a3e2191
kyranjamie added a commit that referenced this issue Oct 6, 2023
@kyranjamie
fix: regtest addresses, closes #4223
94367de
kyranjamie added a commit that referenced this issue Oct 6, 2023
@kyranjamie
fix: regtest addresses, closes #4223
1470bec
github-merge-queue bot pushed a commit that referenced this issue Oct 6, 2023
@kyranjamie
fix: regtest addresses, closes #4223
eedbed5
@kyranjamie kyranjamie mentioned this issue Oct 10, 2023
Merged
kyranjamie pushed a commit that referenced this issue Oct 11, 2023
@semantic-release-bot
chore(release): 6.10.0
eaa1b12 
## [6.10.0](v6.9.2...v6.10.0) (2023-10-11)

### Features

* stacks multisig support, closes [#3889](#3889) ([9dabfc2](9dabfc2))

### Bug Fixes

* outdated version warning ([d56b52c](d56b52c))
* outdated version warning ([c0e859c](c0e859c))
* regtest addresses, closes [#4223](#4223) ([eedbed5](eedbed5))

### Internal

* build job ([917a00b](917a00b))
* improve pr-time messaging ([f26c5fe](f26c5fe))
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@kyranjamie @pete-watters
fix: regtest addresses, closes leather-io#4223
49e5031
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.10.0
eb5ea49 
## [6.10.0](leather-io/extension@v6.9.2...v6.10.0) (2023-10-11)

### Features

* stacks multisig support, closes [leather-io#3889](leather-io#3889) ([9dabfc2](leather-io@9dabfc2))

### Bug Fixes

* outdated version warning ([d56b52c](leather-io@d56b52c))
* outdated version warning ([c0e859c](leather-io@c0e859c))
* regtest addresses, closes [leather-io#4223](leather-io#4223) ([eedbed5](leather-io@eedbed5))

### Internal

* build job ([917a00b](leather-io@917a00b))
* improve pr-time messaging ([f26c5fe](leather-io@f26c5fe))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyranjamie kyranjamie

Labels
area:networks bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: regtest addresses, closes #4223 leather-io/extension
4 participants
@markmhendrickson @kyranjamie @fbwoolf @stjepangolemac