Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/tuesday #4341

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Release/tuesday #4341

merged 7 commits into from
Oct 11, 2023

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Oct 10, 2023

Copy link
Contributor

@alter-eggo alter-eggo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two commits with same text fix: outdated version warning

Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left some style nits

@kyranjamie
Copy link
Collaborator Author

there are two commits with same text fix: outdated version warning

That was my bad, but too late, it's in main and don't want to force push.

@pete-watters legit feedback, but also too late. Feel free to open issues/address these

@kyranjamie kyranjamie merged commit a073802 into main Oct 11, 2023
@kyranjamie kyranjamie deleted the release/tuesday branch October 11, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants