Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to send Ordinals, confirmation screen does not appear #4444

Closed
brandonmarshall-tm opened this issue Oct 26, 2023 · 8 comments · Fixed by #4449
Closed

Unable to send Ordinals, confirmation screen does not appear #4444

brandonmarshall-tm opened this issue Oct 26, 2023 · 8 comments · Fixed by #4449
Assignees
@pete-watters
Labels
area:ordinals area:send bug Functionality broken bug-p1 Critical functionality broken for many customers, with no clear workarounds

Comments

@brandonmarshall-tm
Copy link

I was trying to preview the "send" flow for sending an Ordinal but encountered a bug.

I am able to input the Send To address and choose my fee, but instead of displaying a confirmation dialog, I am sent to a blank modal.

Video:

leatherbug.mp4
@markmhendrickson markmhendrickson added bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds area:send area:ordinals labels Oct 27, 2023
@fbwoolf
Copy link
Contributor

fbwoolf commented Oct 27, 2023

This seems like a routing issue @pete-watters, didn't you change some stuff with routing recently?

@pete-watters
Copy link
Contributor

Yes it does. I can take a look at it but I won't get to it until 1/11

@markmhendrickson
Copy link
Collaborator

@brandonmarshall-tm just to confirm here – the inscription does send in any case?

@pete-watters pete-watters added bug-p1 Critical functionality broken for many customers, with no clear workarounds and removed bug-p2 Critical functionality broken for few users, with no clear workarounds labels Oct 27, 2023
@pete-watters
Copy link
Contributor

Checking this and it's blocking send of ordinals 😭 I'll try fix ASAP.

It is related to routing and introduced was here: https://github.com/leather-wallet/extension/pull/4325/files

If you open the app in full tab you can see the problem.

  • AS a user
  • WHEN I try to send an ordinal
  • AND after entering an address and pressing Send
  • THEN I get send to an incorrect route - send/ordinal-inscription/send/ordinal-inscription/choose-fee
  • AND I see the choose fee modal
  • WHEN I choose my fee I go to - send/ordinal-inscription/send/ordinal-inscription/choose-fee/send/ordinal-inscription/review

This sends users to a non-existant place and they can't send their ordinal

@markmhendrickson
Copy link
Collaborator

Thanks for jumping on it. Let's also add an integration test to prevent regression in the future, either as part of the patch or fast-follow?

@brandonmarshall-tm
Copy link
Author

Thanks Pete! Just confirming that this results in the Inscription not being sent because I don't get to the Review screen where I "Confirm" the transaction.

@pete-watters
Copy link
Contributor

@markmhendrickson I can spent the next hour or so trying to fix it, then I have to go AFK for a few hours but can continue tomorrow if needed

pete-watters added a commit that referenced this issue Oct 27, 2023
@pete-watters
fix: send ordinal routes, closes #4444
fd96bb3
@pete-watters pete-watters linked a pull request Oct 27, 2023 that will close this issue
fix: send ordinal routes, closes #4444 #4449
Merged
@pete-watters
Copy link
Contributor

I managed to implement a fast fix but when I try and send an ordinal it still fails:

Kapture.2023-10-27.at.16.35.41.mp4

I'm not sure if this is related to something I missed or a general fail. I can keep looking at it.

It's tricky to add an integration test as to test it I need an ordinal to send but I will try and add something to do that

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2023
@pete-watters @kyranjamie
fix: send ordinal routes, closes #4444
dc209c2
@kyranjamie kyranjamie mentioned this issue Oct 30, 2023
Merged
kyranjamie pushed a commit that referenced this issue Oct 30, 2023
@semantic-release-bot
chore(release): 6.14.0
efe6602 
## [6.14.0](v6.13.0...v6.14.0) (2023-10-30)

### Features

* removed stacks/ui types and unnecessary data-testids ([5c85448](5c85448))

### Bug Fixes

* add default type to button, closes [#4333](#4333) ([433216f](433216f))
* incorrect ui with psbt listing tx, closes [#4428](#4428) ([e83db28](e83db28))
* remove query options from btc fees, closes [#4198](#4198) ([c7d80eb](c7d80eb))
* removed unnecessary forwardwithrefs ([fc69b0f](fc69b0f))
* send ordinal routes, closes [#4444](#4444) ([dc209c2](dc209c2))
* swap console logs, closes [#4438](#4438) ([e8fa72f](e8fa72f))
* swaps min to receive format, closes [#4442](#4442) ([c5cf61c](c5cf61c))
* tx req fee error, closes [#4231](#4231) ([190868a](190868a))

### Internal

* import prettier config from monorepo, closes [#4268](#4268) ([733e503](733e503))
* post-release merge back ([efee04f](efee04f))
* remove icon transition, closes [#4332](#4332) ([b75b20a](b75b20a))
@pete-watters pete-watters mentioned this issue Nov 1, 2023
Closed
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@pete-watters
fix: send ordinal routes, closes leather-io#4444
ed6776b
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.14.0
ca03af4 
## [6.14.0](leather-io/extension@v6.13.0...v6.14.0) (2023-10-30)

### Features

* removed stacks/ui types and unnecessary data-testids ([5c85448](leather-io@5c85448))

### Bug Fixes

* add default type to button, closes [leather-io#4333](leather-io#4333) ([433216f](leather-io@433216f))
* incorrect ui with psbt listing tx, closes [leather-io#4428](leather-io#4428) ([e83db28](leather-io@e83db28))
* remove query options from btc fees, closes [leather-io#4198](leather-io#4198) ([c7d80eb](leather-io@c7d80eb))
* removed unnecessary forwardwithrefs ([fc69b0f](leather-io@fc69b0f))
* send ordinal routes, closes [leather-io#4444](leather-io#4444) ([dc209c2](leather-io@dc209c2))
* swap console logs, closes [leather-io#4438](leather-io#4438) ([e8fa72f](leather-io@e8fa72f))
* swaps min to receive format, closes [leather-io#4442](leather-io#4442) ([c5cf61c](leather-io@c5cf61c))
* tx req fee error, closes [leather-io#4231](leather-io#4231) ([190868a](leather-io@190868a))

### Internal

* import prettier config from monorepo, closes [leather-io#4268](leather-io#4268) ([733e503](leather-io@733e503))
* post-release merge back ([efee04f](leather-io@efee04f))
* remove icon transition, closes [leather-io#4332](leather-io#4332) ([b75b20a](leather-io@b75b20a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:ordinals area:send bug Functionality broken bug-p1 Critical functionality broken for many customers, with no clear workarounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: send ordinal routes, closes #4444 leather-io/extension
4 participants
@markmhendrickson @pete-watters @fbwoolf @brandonmarshall-tm