fix: send ordinal routes, closes #4444 #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
commented
Oct 27, 2023
| tx: hex, | ||
| }, | ||
| }); | ||
| return navigate( |
There was a problem hiding this comment.
I need to look into this more as if I don't compose the route like this I get a weird error when trying to send
kyranjamie
approved these changes
Oct 30, 2023
|
Merging already for release |
I tried that and it wasn't working. I can check a cleaner solution, I just wanted to get a fix out ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some introduced errors with send ordinal routing.
I got the routes fixed but sending the actual ordinal errors as you can see here:
Kapture.2023-10-27.at.16.35.41.mp4