Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runes] Asset list UI improvements #5246

Closed
4 tasks done
fbwoolf opened this issue Apr 17, 2024 · 2 comments · Fixed by #5247
Closed
4 tasks done

[Runes] Asset list UI improvements #5246

fbwoolf opened this issue Apr 17, 2024 · 2 comments · Fixed by #5247
Assignees

Comments

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 17, 2024

  • The caption should say "Runes" not "RUNE"
  • If the spaced name is available, show that for the rune name
  • Add the currency symbol
  • Handle decimals in balance
@fbwoolf fbwoolf self-assigned this Apr 17, 2024
@fbwoolf fbwoolf linked a pull request Apr 17, 2024 that will close this issue
fbwoolf added a commit that referenced this issue Apr 17, 2024
@kyranjamie
Copy link
Collaborator

What tests can we write to ensure Runes functionality works?

@314159265359879
Copy link
Contributor

I am not sure we should add currency symbol, or we should be mindful of where we show it. I forse some issues. Firstly confusion if placed to the right of the amount because we're already placing symbols there to show thousands, millions. And secondly because I see options to add emoji's as symbols, will those get displayed properly?

The Currency symbol should be placed to the left of the amount as to not confuse it with the K, M, B, T, we use for thousands and millions etc. Or perhaps in the sphere where the rune logo is now. Keeping it black with white symbol could still help users identify it as rune?

Runes will go up to ~3.4*10^38th max supply our wallet only uses shorthand upto T(rillion) then it displays the number.
image

t 100 instead of 100 t in case of The Best Rune AAB example:
image

github-merge-queue bot pushed a commit that referenced this issue Apr 18, 2024
kyranjamie pushed a commit that referenced this issue Apr 18, 2024
## [6.35.0](v6.34.0...v6.35.0) (2024-04-18)

### Features

* filter out runes utxos, closes [#5207](#5207) ([1e02992](1e02992))

### Bug Fixes

* add default runes symbol ([b3109ed](b3109ed))
* check utxo fallback error, closes [#5250](#5250) ([321a00a](321a00a))
* duplicated connect btn, closes [#5255](#5255) ([2655c0f](2655c0f))
* **ledger:** no signer breaking homepage ([7624c0a](7624c0a))
* rpc send transfer data, closes [#5243](#5243) ([1858348](1858348))
* runes ui, closes [#5246](#5246) ([b4dcf87](b4dcf87))

### Internal

* post-release merge back ([75c4f5d](75c4f5d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants