Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - Signer Fix #5264

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Release - Signer Fix #5264

merged 9 commits into from
Apr 18, 2024

Conversation

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 18, 2024

Why would we release this w/out Runes included?

@pete-watters
Copy link
Contributor Author

Why would we release this w/out Runes included?

I've added the Runes UI work #5246 . I didn't want to merge your PR again.

If there is more stuff to add we can before releasing. Maybe this PR? #5179

@pete-watters
Copy link
Contributor Author

We will need to add #5262 also

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 18, 2024

If there is more stuff to add we can before releasing. Maybe this PR? #5179

We can leave #5179 for the next release. I am still finishing some refactoring there.

@pete-watters pete-watters requested a review from fbwoolf April 18, 2024 13:57
@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 18, 2024

I forgot to add the default Runes symbol to my last PR. I will get the change merged then update the release branch.

@pete-watters pete-watters linked an issue Apr 18, 2024 that may be closed by this pull request
@kyranjamie kyranjamie merged commit e9c8503 into main Apr 18, 2024
71 checks passed
@kyranjamie kyranjamie deleted the release/signer-fix branch April 18, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unexpected Application Error" after updating Chrome
4 participants