fix: refactor error label to align icon and make text consistent size #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
force-pushed
the
fix/4166/error-icon-alignment
branch
from
7acdfe1 to
bbcdc95
Compare
pete-watters
force-pushed
the
fix/4166/error-icon-alignment
branch
from
bbcdc95 to
1c1bde6
Compare
kyranjamie
approved these changes
Nov 3, 2023
fbwoolf
reviewed
Nov 3, 2023
fbwoolf
approved these changes
Nov 3, 2023
pete-watters
added
effort:small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
ErrorLabelcomponent so that the text and icon line up correctly.It also standardises the font size and colour we are using