feat: support ledger sign psbt #4489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alter-eggo
commented
Nov 7, 2023
•
alter-eggo
commented
feat: support btc testnet handling
kyranjamie
reviewed
Nov 7, 2023
Comment on lines
+46
to
+53
| const requestToken = searchParams.get('request'); | ||
| if (requestToken) { | ||
| return navigate(RouteUrls.ConnectLedger + `?request=${requestToken}`, { | ||
| replace: true, | ||
| relative: 'route', | ||
| state: { tx: bytesToHex(psbt) }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
I don't think it's necessary to do any special handling here because request token is already persisted in initialSearchParams
kyranjamie
force-pushed
the
feat/ledger-rebased
branch
5 times, most recently
from
5c31cd4 to
3215076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.