fix: sip10 tokens ledger send form #4492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alter-eggo
force-pushed
the
fix/sip10-ledger
branch
from
2a8c463 to
8c983c0
Compare
kyranjamie
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Thanks for fixing @alter-eggo.
Separately, let's think of a solution for this that doesn't involve any whenWallet logic. Better than these components are rendered conditionally based on the existence of a key, rather than wallet type.
But, as this is a P1, let's merge and release this ASAP.
Comment on lines
27
to
28
| {hasStacksKeys && <StacksFungibleTokenAssetList assetBalances={stacksFtAssetBalances} />} | ||
| </> |
There was a problem hiding this comment.
Is hasStacksKeys needed? We pass the assetBalances to this component, and we could only ever know what they are if the user does have stacks keys.
There was a problem hiding this comment.
yeah, checked, there is no need in hasStacksKeys here
|
Also please amend commit with ref to #4491 |
alter-eggo
force-pushed
the
fix/sip10-ledger
branch
from
8c983c0 to
c2a7cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix broken sip10 tokens send flow in ledger mode