Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: stacks removal part 2, closes #4381 #4511

Merged
merged 2 commits into from
Nov 13, 2023
Merged

chore: stacks removal part 2, closes #4381 #4511

merged 2 commits into from
Nov 13, 2023

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Nov 13, 2023 •
edited by github-actions bot
Loading

Try out this version of Leather — download extension builds.

@pete-watters pete-watters requested a review from fbwoolf November 13, 2023 12:57
@pete-watters pete-watters marked this pull request as ready for review November 13, 2023 12:57
@pete-watters pete-watters force-pushed the refactor/remove-stacks-ui-part-2 branch from 53863ef to da525a6 Compare November 13, 2023 13:06
@pete-watters
Copy link
Contributor Author

@fbwoolf I got the rest of my allocation done apart from the theme. I couldn't resist continuing on so I did a few more. All thats really outstanding now is:

  • theme
  • test app
  • amount-field

Screenshot 2023-11-13 at 13 07 39

I suggest we do amount-field and test-app and see how things look then remove the theme and hope.

fbwoolf
fbwoolf approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@fbwoolf fbwoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge 👍

@pete-watters pete-watters merged commit 6a0f62c into refactor/remove-stacks-ui-part-3 Nov 13, 2023
17 of 18 checks passed
@pete-watters pete-watters deleted the refactor/remove-stacks-ui-part-2 branch November 13, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbwoolf fbwoolf fbwoolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pete-watters @fbwoolf