chore: refactor setpassword bars to fix bug #4519
Conversation
| const { strengthColor, strengthResult } = props; | ||
|
|
||
| export function PasswordStrengthIndicator({ | ||
| password, |
There was a problem hiding this comment.
I'm passing password now also so that if users delete what they have typed it clears the bars
pete-watters
force-pushed
the
refactor/remove-stacks-ui-part-3-tests
branch
from
a6a349a to
25e4c7e
Compare
| @@ -1,6 +1,6 @@ | |||
| import { PasswordStrength, ValidatedPassword } from '@app/common/validation/validate-password'; | |||
|
|
|||
| export const defaultColor = 'accent.text-subdued'; | |||
| export const defaultColor = 'accent.background-secondary'; | |||
There was a problem hiding this comment.
I changed this as it wasn't appearing with 'accent.text-subdued'
|
I'll merge this but some work is still needed regarding the colours and I'm not sure why. In the original video posted you can see the colours working however when I went to try and swap I noticed this earlier but once I got it working it was working OK. For some reason Kapture.2023-11-15.at.13.21.53.mp4 |
pete-watters
merged commit d4885b1
into
refactor/remove-stacks-ui-part-3
|
Thanks for fixing @pete-watters! |
No problem 👍 There could be more to do. The colours worked but now they don't and I don't know why. It may be to do with runtime values, I'll check
|
This PR refactors the
PasswordStrengthindicator to help migrate it and fix bugs found.You can see a before + after below with:
Kapture.2023-11-15.at.11.50.27.mp4