Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): wait for sign out to finish before navigating to /get-started #4531

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix(auth): wait for sign out to finish before navigating to /get-started #4531

merged 1 commit into from
Nov 16, 2023

Conversation

edgarkhanzadian
Copy link
Contributor

@edgarkhanzadian edgarkhanzadian commented Nov 16, 2023 •
edited by github-actions bot
Loading

Try out this version of Leather — download extension builds.

Wait for sign out promise to finish before navigating out

lockedSignOut.mov

@edgarkhanzadian edgarkhanzadian added this pull request to the merge queue Nov 16, 2023
Merged via the queue into dev with commit 5630364 Nov 16, 2023
26 checks passed
@edgarkhanzadian edgarkhanzadian deleted the fix/sign-out-locked-screen branch November 16, 2023 13:45
@edgarkhanzadian edgarkhanzadian linked an issue Nov 16, 2023 that may be closed by this pull request
Signing out when locked leads to, passwords modal to still show and then an Unexpected application error. #4206
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pete-watters pete-watters pete-watters approved these changes

@kyranjamie kyranjamie Awaiting requested review from kyranjamie

@fbwoolf fbwoolf Awaiting requested review from fbwoolf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signing out when locked leads to, passwords modal to still show and then an Unexpected application error.
2 participants
@edgarkhanzadian @pete-watters