Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: axios get request for wallet config #4545

Merged
merged 2 commits into from
Nov 20, 2023
Merged

fix: axios get request for wallet config #4545

merged 2 commits into from
Nov 20, 2023

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Nov 20, 2023 •
edited by github-actions bot
Loading

Try out this version of Leather — download extension builds.

Fixes:

  • Axios get request for wallet config
  • HiroWalletProvider was still being used in tests

@fbwoolf fbwoolf changed the title fix: provider name in tests fix: axios get request for wallet config Nov 20, 2023
@fbwoolf fbwoolf linked an issue Nov 20, 2023 that may be closed by this pull request
CI bug: flaky playwright tests #4502
Closed
@fbwoolf fbwoolf added this pull request to the merge queue Nov 20, 2023
Merged via the queue into dev with commit 3ad4b06 Nov 20, 2023
26 checks passed
@fbwoolf fbwoolf deleted the fix/tests-provider branch November 20, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

@pete-watters pete-watters Awaiting requested review from pete-watters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI bug: flaky playwright tests
2 participants
@fbwoolf @kyranjamie