Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fee title in increase fee form #4795

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Jan 10, 2024

Try out this version of Leather — Extension build, Test report

small ui fixes

Screenshot 2024-01-10 at 15 53 46
Screenshot 2024-01-10 at 15 54 58

Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alter-eggo alter-eggo added this pull request to the merge queue Jan 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2024
@@ -44,26 +44,21 @@ export function IncreaseFeeField(props: IncreaseFeeFieldProps): React.JSX.Elemen
showReset={showResetMultiplier}
onSelectMultiplier={onSelectMultiplier}
/>
<Flex>
<styled.label display="block" textStyle="body.02" mb="space.02" htmlFor="fee">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep the label here for accessibility? Shouldn't we just hide it or wrap the input?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, have hidden it

@alter-eggo alter-eggo added this pull request to the merge queue Jan 11, 2024
Merged via the queue into dev with commit 0de3900 Jan 11, 2024
29 checks passed
@alter-eggo alter-eggo deleted the fix/ui-increase-fee branch January 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants