refactor: radii and keyframe #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fbwoolf
force-pushed
the
refactor/radii-and-keyframe
branch
from
eb3db7e to
1434408
Compare
fbwoolf
force-pushed
the
refactor/radii-and-keyframe
branch
from
1434408 to
be71353
Compare
src/app/components/secret-key/mnemonic-key/mnemonic-input-field.tsx
Outdated
Show resolved
Hide resolved
pete-watters
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Great work here @fbwoolf and thanks for the heads up.
Code LGTM 👍
kyranjamie
approved these changes
Jan 15, 2024
fbwoolf
force-pushed
the
refactor/radii-and-keyframe
branch
from
be71353 to
a53110b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates components with the new radii token sizes. I'm not sure it is possible to catch all design changes here, but I did my best and def a good step. I think the container work should rebase on these changes once merged and do another pass to make sure matches new designs. cc @pete-watters