Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: insufficient balance error #4849

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix: insufficient balance error #4849

merged 1 commit into from
Jan 24, 2024

Conversation

edgarkhanzadian
Copy link
Contributor

@edgarkhanzadian edgarkhanzadian commented Jan 23, 2024 •
edited by github-actions bot
Loading

Try out this version of Leather — Extension build, Test report

We should filter out uneconomical UTXOs to save users' money.

In this case, those are going to be the ones that are more expensive to send than their value.

@edgarkhanzadian edgarkhanzadian linked an issue Jan 23, 2024 that may be closed by this pull request
Insufficient balance error at 0.0001 BTC, yet available balance says 0.0023 BTC #4505
Closed
kyranjamie
kyranjamie approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edgar, LGTM

Can you also rebase away the commit that fixes the lint error? No need for this in global git history. Also, is there an issue you can reference

src/app/query/bitcoin/fees/fee-estimates.hooks.ts Outdated Show resolved Hide resolved
@edgarkhanzadian edgarkhanzadian force-pushed the fix/insufficient-balance-error branch from 8cce77c to 66f3b91 Compare January 24, 2024 10:17
@edgarkhanzadian edgarkhanzadian force-pushed the fix/insufficient-balance-error branch from 43df97f to 546841b Compare January 24, 2024 10:18
@edgarkhanzadian edgarkhanzadian added this pull request to the merge queue Jan 24, 2024
Merged via the queue into dev with commit a6e116c Jan 24, 2024
27 of 28 checks passed
@edgarkhanzadian edgarkhanzadian deleted the fix/insufficient-balance-error branch January 24, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insufficient balance error at 0.0001 BTC, yet available balance says 0.0023 BTC
2 participants
@edgarkhanzadian @kyranjamie