Fix: nested button tooltip error #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarkhanzadian
force-pushed
the
fix/nested-button-tooltip-error
branch
from
43d5368 to
6c3697b
Compare
kyranjamie
approved these changes
Jan 25, 2024
edgarkhanzadian
force-pushed
the
fix/nested-button-tooltip-error
branch
from
a575704 to
3cea343
Compare
|
@kyranjamie done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4835
This PR fixes nested button tags and nested tag inside of tag + a bit of refactor on some parts of the code. Using
asChildprop on trigger uses the child component as a base for a tooltip trigger.I encountered another issue with a tooltip though. Sometimes we need to keep tooltip opened when clicking on the button (E.g. we click on a copy button and we need to keep displaying the tooltip with a title "Copied!"), but it seems like radix-ui tooltip doesn't support that kind of a behavior, ref: radix-ui/primitives#2029