Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sign out of the wallet before proceeding with ledger sign in #4870

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix: sign out of the wallet before proceeding with ledger sign in #4870

merged 1 commit into from
Jan 26, 2024

Conversation

edgarkhanzadian
Copy link
Contributor

@edgarkhanzadian edgarkhanzadian commented Jan 26, 2024 •
edited by github-actions bot
Loading

Try out this version of Leather — Extension build, Test report

Fixes #4868

We should run sign out before proceeding with ledger sign in.

Test:

p1-key-fix.mov

@edgarkhanzadian edgarkhanzadian added this pull request to the merge queue Jan 26, 2024
Merged via the queue into dev with commit aa214c8 Jan 26, 2024
28 checks passed
@edgarkhanzadian edgarkhanzadian deleted the fix/p1-secret-keys-fix branch January 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbwoolf fbwoolf fbwoolf approved these changes

@kyranjamie kyranjamie Awaiting requested review from kyranjamie

@pete-watters pete-watters Awaiting requested review from pete-watters

@alter-eggo alter-eggo Awaiting requested review from alter-eggo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent software key from creating an address when using Ledger
2 participants
@edgarkhanzadian @fbwoolf