fix: onboarding gate in ledger mode #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
approved these changes
Jan 26, 2024
edgarkhanzadian
approved these changes
Jan 26, 2024
|
|
||
| if ( | ||
| keyDetails?.type === 'software' && | ||
| hasAlreadyMadeWalletAndPlaintextKeyInMemory(keyDetails.encryptedSecretKey, currentInMemoryKey) | ||
| (keyDetails?.type === 'software' && |
There was a problem hiding this comment.
This works but it's very tricky to read with somewhat of a ternary and function call inside of an if.
I'd go for a small refactor to make it easier to understand
const isLedger = useHasLedgerKeys();
const hasKeyInMemory = hasAlreadyMadeWalletAndPlaintextKeyInMemory(
keyDetails.encryptedSecretKey,
currentInMemoryKey
);
const canGoHome = (keyDetails?.type === 'software' && hasKeyInMemory) || isLedger;
if (canGoHome){
...
For now lets leave it as is, working well but in future I think small refactors like that are worth it
There was a problem hiding this comment.
completely agree here, just was in a hurry a bit
There was a problem hiding this comment.
yeah thats fine, and understandable! nice job getting it fixed so quickly 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds redirect back to home screen if user has ledger keys and tries go back to welcome page
Screen.Recording.2024-01-26.at.19.47.50.mov