Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): mnemonic value state #4892

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix(input): mnemonic value state #4892

merged 1 commit into from
Feb 5, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Feb 2, 2024 •
edited by github-actions bot
Loading

Try out this version of Leather — Extension build, Test report

2024-02-02-000078.mp4

(Still a bug where first input shows error if you use a key replace/paste, but pretty much unnoticeable when it transitions right away)

pete-watters
pete-watters approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

fabric-8
fabric-8 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@fabric-8 fabric-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, works and looks great — happy to see this getting done SO FAST 🚀🚀🚀

@kyranjamie kyranjamie added this pull request to the merge queue Feb 5, 2024
Merged via the queue into dev with commit 5fa284a Feb 5, 2024
28 checks passed
@kyranjamie kyranjamie deleted the fix/mnemonic-entry branch February 5, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabric-8 fabric-8 fabric-8 approved these changes

@pete-watters pete-watters pete-watters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyranjamie @pete-watters @fabric-8