refactor: esm webpack #4942
Merged
refactor: esm webpack #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
experimental/use-esm
branch
7 times, most recently
from
4823ccc to
682a5a7
Compare
kyranjamie
requested review from
alter-eggo,
fbwoolf,
pete-watters and
edgarkhanzadian
alter-eggo
approved these changes
Feb 15, 2024
kyranjamie
force-pushed
the
experimental/use-esm
branch
2 times, most recently
from
b9e403a to
a2be79e
Compare
fbwoolf
approved these changes
Feb 15, 2024
pete-watters
approved these changes
Feb 16, 2024
kyranjamie
force-pushed
the
experimental/use-esm
branch
from
a2be79e to
ad5a562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the extension to an ES Module,
"type": "module". This means that node expects all*.jsfiles to be modules, unless otherwise stated by the*.cjsfile extension. I've migrated most configs over to ESM, bar those causing issues or not worth the time, eslint, webpack modules for test app.These changes make it easier to import from the monorepo with modern tooling.
We don't allow
export defaultin our app for a handful of reasons, but you'll see it here and many configs expect a default export.More info here, recommended reading https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c