feat: introduce getXpub RPC method

[vinlim]

This PR introduces a new getXpub RPC method to facilitate easy access to the wallet's xpub, addressing the requirements outlined in issue #4785. This method enabled various use cases, such as accounting and non-custodial services, by allowing permissioned access to the xpub. It simplifies integration processes, improves user experience, and maintains security standards.

Screen.Recording.2024-02-19.at.5.27.51.PM.mov

[kyranjamie]

Thanks for the PR @vinlim

If we're to allow users to get xpub, I wonder if this should just be exposed from the same API we have now, getAddresses rather than creating a new API.

[vinlim]

Thanks for the input @kyranjamie .

If we're to allow users to get xpub, I wonder if this should just be exposed from the same API we have now, getAddresses rather than creating a new API.

Exposing the xpub from the same getAddresses API while being much simpler, may introduce privacy risks by potentially allowing services to track all past and future transactions of a wallet, beyond their need for the address information. Maintaining separate API methods may be better aligned with the principle of least privilege. Ensuring services access only the data they need based on the permission granted.

Also, both BTCKit & WebBTC suggest that getAddresses is called to obtain an on-chain address from the wallet, with a similar proposed response. Adding xpub information may not align with the standard/specification.

Looking forward to your thoughts on this approach.

[shivaenigma]

If leather wallet has multiple accounts, connect should ask which account to connect to

[shivaenigma]

@markmhendrickson looking to have this merged soon. Let us know how we can help to expedite the process

[markmhendrickson]

@kyranjamie thoughts on the above comments for proceeding here?

[markmhendrickson]

If leather wallet has multiple accounts, connect should ask which account to connect to

We're releasing this enhancement soon

[kyranjamie]

Sorry for the delay reviewing this work, we've been discussing it internally.

We're okay with this API, however before merging, it'd be great if you could:

• Format code per our linting standards, prettier, eslint etc yarn lint
• Write automated tests using Playwright. See tests/ folder for examples of how this is done

[vinlim]

Sorry for the delay reviewing this work, we've been discussing it internally.

We're okay with this API, however before merging, it'd be great if you could:

• Format code per our linting standards, prettier, eslint etc yarn lint
• Write automated tests using Playwright. See tests/ folder for examples of how this is done

Hi @kyranjamie thanks for the feedback. As suggested, I've added a test and formatted code style per yarn lint. It's ready for another review. Please let me know if further improvement is required.

[kyranjamie]

@vinlim I've pushed your PR here to let it run properly against our CI and there are many failures. Are you able to take a look at these?

[vinlim]

Hi @kyranjamie it seems I've imported the incorrect component that is resulting in the error. I've rectified it. Appreciate you'd try it again.

[cnohall]

Hello, just wondering what's the status on this?