Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings btn ui #4981

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: settings btn ui #4981

merged 1 commit into from
Feb 27, 2024

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Feb 26, 2024

Try out this version of Leather — Extension build, Test report

This pr fixes settings menu overlay btn
Screenshot 2024-02-26 at 16 15 47

fixed:

Screenshot 2024-02-26 at 16 16 53

@alter-eggo alter-eggo enabled auto-merge February 26, 2024 13:24
@alter-eggo alter-eggo disabled auto-merge February 26, 2024 13:24
@alter-eggo alter-eggo added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@fbwoolf
Copy link
Contributor

fbwoolf commented Feb 26, 2024

@pete-watters is this nec to merge and do since you refactoring the settings menu in your work? Will this cause conflicts for you that are unnec at this point?

Copy link
Contributor

@fbwoolf fbwoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor so just approving though it is being replaced.

@alter-eggo alter-eggo added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2024
@alter-eggo alter-eggo added this pull request to the merge queue Feb 27, 2024
Merged via the queue into dev with commit b3146a2 Feb 27, 2024
28 checks passed
@alter-eggo alter-eggo deleted the feat/settings-ui branch February 27, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants