test: fix playwright select interactive item #5013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
fix/item-interactive-clickable
branch
from
0bd0753 to
fb7733b
Compare
pete-watters
approved these changes
Mar 4, 2024
kyranjamie
force-pushed
the
fix/item-interactive-clickable
branch
from
fb7733b to
cde1ff7
Compare
|
Thx @kyranjamie, was a hard test failure for me to pinpoint problem over wkend. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pointer-events: 'none';fix #5005 had the unintended side effect of the clickable area being smaller than the background, which isn't good.This PR removes that property, and manages to fix the test using the
click({ force: true })arg. (Edit: hadn't realised you also used this in your PR @fbwoolf 👍🏼 )https://playwright.dev/docs/input
Also fixes padding issue on Select account page