feat: icon button #5020
Closed
feat: icon button #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooters, refactor onboarding, ref #4371
This was
linked to
issues
Mar 4, 2024
pete-watters
reviewed
Mar 5, 2024
pete-watters
force-pushed
the
chore/4370/design-system-containers
branch
2 times, most recently
from
c97312b to
9c511e5
Compare
pete-watters
requested changes
Mar 5, 2024
There was a problem hiding this comment.
This PR is great but marking as Needs work to stop it getting merged as I already cherry picked the last two commits into the containers branch, thanks Fara!
Yesterday I made a real rebase mess for myself merging so I'll just picking in the commits until this gets over the line.
pete-watters
force-pushed
the
chore/4370/design-system-containers
branch
from
716ccaa to
f25e404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BRANCHED OFF THE CONTAINER WORK
This PR refactors our current
ActionButton, which uses the RadixAccessibleIconcomponent, into a UI component calledIconButtonto make our buttons using icons consistent and accessible; showing the label is optional. Stories included.Also, addressed the large checkmarks/alignment issues on the
AllowDiagnosticsscreen...EDIT: Note, I took the autofocus off the allow diagnostics button bc everyone mentions it like they don't expect it? You can put back if want to keep.