Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag #5023

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat: tag #5023

merged 1 commit into from
Mar 5, 2024

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Mar 5, 2024

Try out this version of Leather — Extension build, Test report

This PR adds the new Tag component with stories per the design spec (see issue).

*I also refactored the Callout to use a recipe with variants bc it seems easier to read imo, but can remove if people prefer data- params?

Screenshot 2024-03-04 at 7 54 56 PM Screenshot 2024-03-04 at 7 55 09 PM Screenshot 2024-03-04 at 7 58 58 PM Screenshot 2024-03-04 at 8 23 42 PM

@fbwoolf fbwoolf linked an issue Mar 5, 2024 that may be closed by this pull request
Copy link
Contributor

@pete-watters pete-watters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@fbwoolf fbwoolf force-pushed the feat/tags branch 3 times, most recently from c2e59c1 to a5feb67 Compare March 5, 2024 16:55
@fbwoolf fbwoolf added this pull request to the merge queue Mar 5, 2024
Merged via the queue into dev with commit 5b37691 Mar 5, 2024
28 checks passed
@fbwoolf fbwoolf deleted the feat/tags branch March 5, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design system: Tags
3 participants