fix: regression on stacking layout #5032
Conversation
kyranjamie
force-pushed
the
fix/locked-spacing
branch
from
da00396 to
6a861ba
Compare
|
Can we put a (visual) regression test in place for this? |
kyranjamie
force-pushed
the
fix/locked-spacing
branch
2 times, most recently
from
b4a9522 to
f2e4099
Compare
Yes ser. Had to do a bit of a refactor as the responsibility of displaying the information, and fetching the data were part of the same component. I've broken these, up, and written a storybook.
|
kyranjamie
force-pushed
the
fix/locked-spacing
branch
from
f2e4099 to
d5ece8f
Compare
kyranjamie
force-pushed
the
fix/locked-spacing
branch
from
d5ece8f to
24e8733
Compare
| <Caption>{balance.amount.toNumber() > 0 && address ? usdBalance : null}</Caption> | ||
| {additionalUsdBalanceInfo} | ||
| </> | ||
| <Caption> |
There was a problem hiding this comment.
Thanks for fixing, this was prob me breaking it implementing the ItemInteractive. I remember encountering this component again recently, questioning if it is really a layout component now when it is just rendering an ItemInteractive that that wraps the ItemLayout? Maybe we don't even need to have the props passed to render here?
| const meta: Meta<typeof StacksBalanceListItemLayout> = { | ||
| component: StacksBalanceListItemLayout, | ||
| tags: ['autodocs'], | ||
| title: 'Feature/StacksBalanceListItem', |
There was a problem hiding this comment.
We should make sure to coordinate with @pete-watters on the new sections being added to our storybook. I noticed in his he has new sections too.
There was a problem hiding this comment.
I actually decided to revert my changes to fit into the current system. Once everything is merged lets review it together.
I had just added Design System/ to the start of the path
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Regression from past fix of #4857
Something changed causing the layout to be broken onto two lines.