Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update wallet-config.json #5040

Closed
wants to merge 1 commit into from
Closed

Conversation

mica000
Copy link

@mica000 mica000 commented Mar 7, 2024

Try out this version of Leather — Extension build, Test report

Update config with new copy for scam banner: "Only install Leather from leather.io or the Chrome Web Store by Google."

@kyranjamie
Copy link
Collaborator

Great job @mica000

One small thing you need to do extra is to keep the commit message format. The same, but in lowercase. Will fix this now.

image

@kyranjamie kyranjamie force-pushed the Chore/update-wallet-config.json branch from a484176 to c6cbde5 Compare March 8, 2024 09:16
@kyranjamie kyranjamie self-requested a review March 8, 2024 09:16
@mica000
Copy link
Author

mica000 commented Mar 8, 2024

@kyranjamie the banner is breaking in the action pop-up...
image

How can I make changes to this PR?
"One small thing you need to do extra is to keep the commit message format."

@mica000
Copy link
Author

mica000 commented Mar 8, 2024

image

Checkin on this again, doesn't look good - let's not release it like this?

@kyranjamie kyranjamie closed this Mar 13, 2024
@kyranjamie kyranjamie deleted the Chore/update-wallet-config.json branch March 25, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants