refactor: item interactive to pressable #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Pressable
Open to pushback on these changes, but thought it would be more inline with sharing components with mobile.
LGTM @fbwoolf, great decision to separate Pressable from LayoutItem. Renaming highlights how they're completely unrelated.
kyranjamie
force-pushed
the
refactor/item-interactive-to-pressable
branch
from
09c2049 to
96320af
Compare
|
Rebasing for storybook link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
ItemInteractiveto use astyled.buttonrather than aBoxcomponent. I also used this issue to rename the component toPressableand separated the files from theItemLayoutcomponent. Open to pushback on these changes, but thought it would be more inline with sharing components with mobile.