feat: change query persister to chrome storage, closes #5153 #5172
Conversation
alter-eggo
force-pushed
the
fix/txs-list-cache
branch
from
402c16e to
7e2de0c
Compare
alter-eggo
force-pushed
the
fix/txs-list-cache
branch
from
7e2de0c to
d11830c
Compare
| @@ -34,7 +34,7 @@ export enum RouteUrls { | |||
| ViewSecretKey = '/view-secret-key', | |||
|
|
|||
| // nested routes must have relative paths | |||
| Activity = 'activity', | |||
| Activity = '/activity', | |||
There was a problem hiding this comment.
Why this change? Maybe this have unintended consequences?
There was a problem hiding this comment.
there is ui bug - if refresh page being on activity tab => tab is not active
There was a problem hiding this comment.
I tested actually, and seems all good
There was a problem hiding this comment.
Changing this will add a warning in the console, that's why I added the comment there:
// nested routes must have relative paths
I think we should solve the refresh bug differently
There was a problem hiding this comment.
I checked and I'm pretty sure I had to change all of these routes here to avoid a console warning but I can't see that now after this change so I think it could be OK.
In future, if you are fixing bugs you should at least have a separate commit message for that fix saying what it is and why in case we need to revisit it
Problem in transactions caching was that txs list size is too big to be cached in local storage, so I changed persister to
chrome.storage.local