Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update stx avatar #5180

Merged
merged 1 commit into from
Apr 9, 2024
Merged

chore: update stx avatar #5180

merged 1 commit into from
Apr 9, 2024

Conversation

fabric-8
Copy link
Contributor

@fabric-8 fabric-8 commented Apr 8, 2024

Try out Leather build dc14f8aExtension build, Test report, Storybook, Chromatic

Updates to the latest stx avatar/logo according to the updated brand guidelines

CleanShot 2024-04-08 at 22 29 23@2x

Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See errors in file changes, dupe prop
image

@kyranjamie
Copy link
Collaborator

kyranjamie commented Apr 8, 2024

When making fixes to your commits, I recommend use of the --amend flag, to change the existing commit, rather than adding new, unimportant ones.

@fabric-8
Copy link
Contributor Author

fabric-8 commented Apr 8, 2024

@kyranjamie Noted, will do so in the future

@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 9, 2024

@fabric-8 if you run git log and copy the commit before yours on the branch, then run get rebase -i <commit> ...you should be able to squash all these into one commit.

@fabric-8 fabric-8 force-pushed the chore/update-stx-avatar branch from e071e35 to dc14f8a Compare April 9, 2024 05:46
@fabric-8
Copy link
Contributor Author

fabric-8 commented Apr 9, 2024

Squashed all unnecessary commits into one ✓

@fabric-8 fabric-8 requested a review from kyranjamie April 9, 2024 05:48
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabric-8 !

@fabric-8 fabric-8 added this pull request to the merge queue Apr 9, 2024
Merged via the queue into dev with commit 03fe093 Apr 9, 2024
28 checks passed
@fabric-8 fabric-8 deleted the chore/update-stx-avatar branch April 9, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants