fix: container when resized #5183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pete-watters
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Thanks @kyranjamie 👍
The re-centring is a bug I needed to fix and forgot.
For the height, I thought it was needed but I have tested it and it's not so its great to remove it.
fbwoolf
approved these changes
Apr 9, 2024
|
This fixes this bug #4886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that container doesn't centre itself when the content is resize. Think it'd be nice to contain the content when this happens.
Also @pete-watters think we can remove the height? We have the min & max height. The height is the default size of the window, but that can change if users resize themselves, reposition with window manager etc
This PR centres the content, which is a very small improvement