feat: filter out runes utxos, closes #5207 #5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbwoolf
force-pushed
the
feat/runes-balances
branch
3 times, most recently
from
3a173b8 to
cf3f7dd
Compare
|
Looks good @alter-eggo, if you rebase on the balances work (now on dev) you should see some more code that adds the remote config for mainnet Runes ...and code so we can go live handling both testnet and mainnet. |
kyranjamie
reviewed
Apr 15, 2024
kyranjamie
reviewed
Apr 15, 2024
kyranjamie
reviewed
Apr 15, 2024
alter-eggo
force-pushed
the
feat/filter-runes-utxos
branch
from
de414d1 to
19f96a9
Compare
fbwoolf
reviewed
Apr 15, 2024
fbwoolf
reviewed
Apr 15, 2024
fbwoolf
reviewed
Apr 15, 2024
alter-eggo
force-pushed
the
feat/filter-runes-utxos
branch
2 times, most recently
from
d616b50 to
1e792db
Compare
fbwoolf
reviewed
Apr 16, 2024
fbwoolf
reviewed
Apr 16, 2024
alter-eggo
force-pushed
the
feat/filter-runes-utxos
branch
3 times, most recently
from
ecccb8e to
1459215
Compare
kyranjamie
approved these changes
Apr 18, 2024
Comment on lines
151
to
154
| // To-DO If there are no runes response, filter out all utxos ? | ||
| if (!data) { | ||
| return []; | ||
| } |
There was a problem hiding this comment.
Wonder if this is indeed too strict? won't this flash a balance of 0 before the data loads?
There was a problem hiding this comment.
hm. let's remove for now
alter-eggo
force-pushed
the
feat/filter-runes-utxos
branch
from
1459215 to
3a40511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr add filtering of utxos with runes from spendable utxos list