fix: add default runes symbol #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fbwoolf
commented
Apr 18, 2024
•
fbwoolf
commented
pete-watters
approved these changes
Apr 18, 2024
kyranjamie
approved these changes
Apr 18, 2024
| @@ -27,7 +27,7 @@ export function RunesAssetItemLayout({ rune }: RunesAssetItemLayoutProps) { | |||
| side="left" | |||
| > | |||
| <styled.span data-testid={rune.rune_name} fontWeight={500} textStyle="label.02"> | |||
| {formattedBalance.value} {rune.symbol} | |||
| {formattedBalance.value} {rune.symbol ?? '¤'} | |||
There was a problem hiding this comment.
Would extract as a const somewhere, as we'll likely use again
There was a problem hiding this comment.
Moved it to when we make the type after the query.
fbwoolf
force-pushed
the
fix/default-runes-symbol
branch
2 times, most recently
from
2df9983 to
fa1cc0f
Compare
fbwoolf
force-pushed
the
fix/default-runes-symbol
branch
from
fa1cc0f to
dcec2ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.