Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rpc send transfer recipient default network #5291

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: rpc send transfer recipient default network #5291

merged 1 commit into from
Apr 22, 2024

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Apr 22, 2024 •
edited by leather-bot
Loading

Try out Leather build d285924 — Extension build, Test report, Storybook, Chromatic

This change was not enough #5288 since we are validating recipient addresses as well
I don't like the implementation of recipient network validation, though otherwise we'll need big refactor to pass network in validation fns

@alter-eggo alter-eggo requested a review from kyranjamie April 22, 2024 12:05
@alter-eggo alter-eggo added this pull request to the merge queue Apr 22, 2024
Merged via the queue into dev with commit 4410185 Apr 22, 2024
29 checks passed
@alter-eggo alter-eggo deleted the fix/recipient-address-check branch April 22, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alter-eggo @kyranjamie